Condition Filter and Map are now Interfaces #921
Merged
+534
−399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/mybatis/dynamic/sql/where/condition/IsInCaseInsensitive.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsInCaseInsensitiveWhenPresent.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsLikeCaseInsensitive.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsNotInCaseInsensitive.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsNotInCaseInsensitiveWhenPresent.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsNotLikeCaseInsensitive.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #917 we added the ability to implement arbitrary conditions. With this PR, we make that easier to do - primarily by extracting the
filterandmapmethods into interfaces that may or may not be implemented. This makes it easier to implement simple conditions and gives developers more choice over what they implement.The built-in conditions all implement both
filterandmap, so there is no impact to existing code.