Skip to content

Update error locations for K2 compiler #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/test/kotlin/nullability/test/ComparisonTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 30))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -81,7 +81,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 31))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down Expand Up @@ -124,7 +124,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 33))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -167,7 +167,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 34))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down Expand Up @@ -210,7 +210,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 34))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -253,7 +253,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 35))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down Expand Up @@ -296,7 +296,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 43))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -339,7 +339,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 44))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down Expand Up @@ -382,7 +382,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 31))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -425,7 +425,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 32))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down Expand Up @@ -468,7 +468,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 40))
.contains(ErrorLocation(9, 20))
}

@Test
Expand Down Expand Up @@ -511,7 +511,7 @@ class ComparisonTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 41))
.contains(ErrorLocation(10, 21))
}

@Test
Expand Down
8 changes: 4 additions & 4 deletions src/test/kotlin/nullability/test/EqualNotEqualTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class EqualNotEqualTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(9, 37))
.contains(ErrorLocation(9, 27))
}

@Test
Expand Down Expand Up @@ -81,7 +81,7 @@ class EqualNotEqualTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 40))
.contains(ErrorLocation(10, 27))
}

@Test
Expand Down Expand Up @@ -124,7 +124,7 @@ class EqualNotEqualTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(10, 38))
.contains(ErrorLocation(10, 28))
}

@Test
Expand Down Expand Up @@ -169,7 +169,7 @@ class EqualNotEqualTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(11, 41))
.contains(ErrorLocation(11, 28))
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/nullability/test/InTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,6 @@ class InTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(11, 26))
.contains(ErrorLocation(11, 21))
}
}
2 changes: 1 addition & 1 deletion src/test/kotlin/nullability/test/NotInTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,6 @@ class NotInTest {
val compilerMessageCollector = compile(source)
assertThat(compilerMessageCollector.errorLocations())
.hasSize(1)
// TODO .contains(ErrorLocation(11, 29))
.contains(ErrorLocation(11, 21))
}
}