Cache Interceptor signature result #3396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucelwl
reviewed
Mar 11, 2025
| @@ -64,6 +67,10 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl | |||
| } | |||
|
|
|||
| private static Map<Class<?>, Set<Method>> getSignatureMap(Interceptor interceptor) { | |||
| return signatureMapCache.computeIfAbsent(interceptor.getClass(), (clazz) -> createSignatureMap(interceptor)); | |||
There was a problem hiding this comment.
Suggest changing it to org.apache.ibatis.util.MapUtil#computeIfAbsent
There was a problem hiding this comment.
Thank you, it seemed that this method did not exist at the time.
|
Thank you for the PR, @Puppy4C ! I did some tests and the effect of this PR was not significant (see the benchmark result). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of Interceptor is static, and I think it should be cached, otherwise every time an operation is performed, a new one will be created, which is a time-consuming operation.