Skip to content

fix: the border around the example checkbox #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ash-wright123 wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −25
Open

fix: the border around the example checkbox #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/components/ExampleCheckbox.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
.container {
position: relative;
}

.checkbox {
accent-color: var(--mui-palette-text-primary);
margin: var(--spacing-1) var(--spacing-1-point-5) var(--spacing-1) var(--spacing-point-5);
width: 15px;
height: 15px;
}

.pseudoFocus {
display: inline-block;
/* border-box so host page box-sizing resets can't shift the outline off-center */
box-sizing: border-box;
/* checkbox 15px + 1px gap + 1px border on each side */
width: 19px;
height: 19px;
border: 1px solid;
border-radius: 3px;
position: absolute;
top: 6px;
left: 2px;
}
31 changes: 6 additions & 25 deletions src/components/ExampleCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,22 @@
import React from 'react'
import PropTypes from 'prop-types'
import { useTheme } from '@mui/material'
import { TouchIndicator } from 'src/components/TouchIndicator'
import styles from 'src/components/ExampleCheckbox.module.css'

export const ExampleCheckbox: React.FC<
React.HTMLAttributes<HTMLInputElement> & {
pseudoFocusColor: string
showTouchIndicator?: boolean
}
> = ({ id, showTouchIndicator, pseudoFocusColor }) => {
const theme = useTheme()
const checkboxSize = '15px'

return (
<div aria-hidden="true" style={{ position: 'relative' }}>
<div aria-hidden="true" className={styles.container}>
<input
aria-hidden={true}
className="example-checkbox"
className={`example-checkbox ${styles.checkbox}`}
defaultChecked={true}
id={'example-' + id}
name={'example-name-' + id}
style={{
accentColor: theme.palette.text.primary,
marginTop: '8px',
marginBottom: '8px',
marginRight: '12px',
marginLeft: '4px',
width: checkboxSize,
height: checkboxSize,
}}
tabIndex={-1}
type="checkbox"
/>
Expand All @@ -38,16 +26,9 @@ export const ExampleCheckbox: React.FC<
{showTouchIndicator && (
<div
aria-hidden="true"
style={{
display: 'inline-block',
height: `calc(${checkboxSize} + 2px)`,
width: `calc(${checkboxSize} + 2px)`,
border: `1px solid ${pseudoFocusColor}`,
borderRadius: '3px',
position: 'absolute',
top: '6px',
left: '2px',
}}
className={styles.pseudoFocus}
// Border color is dynamic — it comes from the institution's brand color
style={{ borderColor: pseudoFocusColor }}
/>
)}
</div>
Expand Down
Loading