Skip to content

aw/CT-1858 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ash-wright123 merged 2 commits into from
Dec 12, 2025
Merged

aw/CT-1858 #262

ash-wright123 merged 2 commits into from
Dec 12, 2025

Conversation

@ash-wright123
Copy link
Collaborator

@ash-wright123 ash-wright123 commented Dec 11, 2025 •
edited
Loading

Issue

https://mxcom.atlassian.net/browse/CT-1858

Changes

  • Changed the styling of password and username field to apply a margin depending on which one is received first.

Testing Instructions

  • open connect and click on gringotts and make sure there are no visual changes
  • open myFakeBank in sand and make sure that the inputs are not overlapping
  • no harm testing

Screenshots

Screenshot 2025-12-11 at 4 34 07 PM Screenshot 2025-12-11 at 4 34 22 PM

@ash-wright123 ash-wright123 self-assigned this Dec 11, 2025
@ash-wright123 ash-wright123 added the Needs Review This item needs review label Dec 11, 2025
Jameson13B
Jameson13B previously approved these changes Dec 12, 2025
View reviewed changes
Copy link
Collaborator

@Jameson13B Jameson13B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Jameson13B
Jameson13B approved these changes Dec 12, 2025
View reviewed changes
Copy link
Collaborator

@Jameson13B Jameson13B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two in one. Thanks Ashley!

@ash-wright123 ash-wright123 merged commit f368d56 into master Dec 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jameson13B Jameson13B Jameson13B approved these changes

@codingLogan codingLogan Awaiting requested review from codingLogan codingLogan is a code owner

@mwclemy mwclemy Awaiting requested review from mwclemy mwclemy is a code owner

@wesrisenmay-mx wesrisenmay-mx Awaiting requested review from wesrisenmay-mx wesrisenmay-mx is a code owner

@emilysallstrom emilysallstrom Awaiting requested review from emilysallstrom emilysallstrom is a code owner

Assignees

@ash-wright123 ash-wright123

Labels

Needs Review This item needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ash-wright123 @Jameson13B