fixes bug to disallow null or invalid directory #12#14
Open
Codher15 wants to merge 1 commit intomweitzel:masterfrom
Open
fixes bug to disallow null or invalid directory #12#14Codher15 wants to merge 1 commit intomweitzel:masterfrom
Codher15 wants to merge 1 commit intomweitzel:masterfrom
Conversation
Author
|
Still waiting for your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the present code of firetower, if a null string is entered in the -d or --directory command, then it defaults it to the current directory. We have modified the code so that if in case a null string is passed in these arguments as directory, then it calls usage and in case of an invalid directory an error message saying "not a directory" is displayed along with call to usage.