Fix: Support custom models for schedule monitor #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses the issue where the package is tightly coupled with
Spatie\ScheduleMonitor\Models\MonitoredScheduledTask
andSpatie\ScheduleMonitor\Models\MonitoredScheduledTaskLogItem
. While thespatie/laravel-schedule-monitor
package allows users to specify custom models for these tables via configuration, the package currently fails to respect those configurations and continues to use the default models.Problem
When custom models are specified in the
config/schedule-monitor.php
file, the package does not switch to using the configured models. This leads to errors when different table names are used.Solution
This fix modifies the package to use the custom models specified in the configuration file for
MonitoredScheduledTask
andMonitoredScheduledTaskLogItem
.All references to the default models have been replaced with dynamic lookups, ensuring that custom models will be used if defined in the config.
Impact
This change ensures that users with custom models or table structures for scheduled tasks can still use the package without issues.