feat: Support customize derivedDataPath #287
Conversation
|
Thanks! Is there any way to add a unit tests for this option to make sure it stays working? |
|
I added a unit test. |
There was a problem hiding this comment.
I don't know if I'm the best one to know if this is the right fix (@rakaramos u up?), but the change looks nice!
| @@ -137,6 +137,26 @@ final class BuildForTestingTests: MuterTestCase { | |||
| .literal(reason: "Could not parse xctestrun at path: some/project.xctestrun") | |||
| ) | |||
| } | |||
|
|
|||
| func test_givenTestArgumentsContainsDerivedDataPath_shouldCopyXCTestrunCorrectly() async throws { | |||
There was a problem hiding this comment.
Typo, but also, is this what you want to call it? Or is it more like test_supportsCustomDerivedDataPath or something?
| func test_givenTestArgumentsContainsDerivedDataPath_shouldCopyXCTestrunCorrectly() async throws { | |
| func test_givenTestArgumentsContainsDerivedDataPath_shouldCopyXCTestRunCorrectly() async throws { |
| state.mutatedProjectDirectoryURL = URL(fileURLWithPath: "/path/to/temp") | ||
| process.stdoutToBeReturned = xcodebuildBuildForTestingOutput() | ||
|
|
||
| _ = try? await sut.run(with: state) |
There was a problem hiding this comment.
You should be able to do this, because the test function is marked throws, unless you expect it to actually throw an error while testing? In that case, I'd probably prefer XCTAssertThrows or an explicit do/catch or something.
| _ = try? await sut.run(with: state) | |
| _ = try await sut.run(with: state) |
There was a problem hiding this comment.
I only provided enough mock data to make the run func execute the copy xctestrun logic, so the run function will eventually throw.
Since I only care about the copy logic getting executed => I used try? here.
|
No idea why CI is failing. Probably just because we haven't debugged it in a while, and something has slipped out of date. There hasn't been a lot of active development around here lately, unfortunately. |
|
@hoangatuan It turns out this was one of the necessary fixes to get the CI working. I'm not sure when Xcode changed this behavior, but previously, we could retrieve the build folder by querying That said, you're more than welcome to review #289. |
Fix issue: #286