Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tanh effect #289

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add tanh effect #289

wants to merge 1 commit into from

Conversation

telephon
Copy link
Contributor

ndr-brt
ndr-brt approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I had this in my personal code, great to see it in SuperDirt directly

@telephon
Copy link
Contributor Author

I'm still unsure about the volume adjustment. Also I wonder whether it would be better as a global effect actually.

@Bubobubobubobubo
Copy link
Contributor

This would be a great addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telephon @Bubobubobubobubo @ndr-brt