Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach dynamic to end of duration #27017

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

mike-spa
Copy link
Contributor

Resolves: can't attach dynamics to end of durations anymore.
image

This was caused by #26848. That PR reserves the alt modifier for the accessible navigation using alt+arrows, but there must be an exception when the shift modifier is also pressed. Shift+alt+arrow is the command for attaching dynamics to end of durations.

The alt modifier is reserved for accessible navigation using alt+arrows... unless there is also shift modifier!

Shift+alt+arrow is needed for attaching dynamics to end of durations.
@mike-spa mike-spa requested review from oktophonie and avvvvve March 10, 2025 17:55
@oktophonie oktophonie added regression nightly Works correctly in the latest released version and is broken in the nightly builds UX/interaction labels Mar 10, 2025
@avvvvve
Copy link

avvvvve commented Mar 10, 2025

@mike-spa Seems to work! But in testing I noticed a small bug (also there in 4.4) that maybe you could fix here.

If I've attached a dynamic to the end of a duration using Opt + Shift + Arrow, when I'm cycling backwards through element selection using Opt + Left, after selecting the dynamic, the next Opt + Left selects something but it's not visible to me (unexpected), then another Opt + Left will select the duration it's attached to. Basically, there's an extra selection step that shouldn't be there.

When cycling forward with Opt + Right, there is no extra selection step (expected).

Screen.Recording.2025-03-10.at.2.50.20.PM.mov

Tested further, and when I move the dynamic to the middle of the measure and attach it to the end of a duration, the same behavior as above happens but the extra step is only when I'm using Opt + Right, not Opt + Left.

Screen.Recording.2025-03-10.at.2.54.25.PM.mov

Also, the order that things are selected in the above video is unexpected. The dynamic is attached to the end of the first 16th note, right? I'd expect, from left to right in that last group of 16ths, selection order should be:

  1. First 16th
  2. Dynamic
  3. Second 16th

But it's

  1. First 16th
  2. Second 16th
  3. Dynamic

@mike-spa
Copy link
Contributor Author

@avvvvve done

@oktophonie oktophonie requested a review from miiizen March 11, 2025 08:54
@mike-spa mike-spa merged commit 8a66e6d into musescore:master Mar 11, 2025
11 checks passed
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression nightly Works correctly in the latest released version and is broken in the nightly builds UX/interaction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants