remove articulation direction indications #26979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These strings are taken straight from SMuFL and auto-generated by For display in the UI you might try to filter out the last word, but that'd probably not work for the translations |
|
The real solution will probably be to introduce a dedicated ArticulationType enum with corresponding TConv methods, instead of identifying articulations by their SymIds. That might solve some other difficulties as well, but is not trivial to do, and will most likely also require some compatibility handling. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26071
This removes the unused (and useless) direction indications for articulations.
Does the trick in the UI, but now we have all names twice …