Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Muse Sounds profile to MuseSounds (with compat) #26977

Merged

Conversation

cbjeukendrup
Copy link
Contributor

Originally I thought about separating the UI display name from the code that's stored in the file, but that seemed to be more work than the solution of this PR. And since it's still not very clear which way we want to go with these profiles, I'd prefer not spending too much time on a complicated advanced solution that will probably be overhauled again.

@cbjeukendrup cbjeukendrup force-pushed the musesounds_profile_rename branch from 01f369b to 76b3f19 Compare March 9, 2025 20:37
@cbjeukendrup
Copy link
Contributor Author

@zacjansheski Testing notes:

  • the profile name in View > Playback Setup should be MuseSounds, not Muse Sounds
  • all other occurrences of this renaming are handled not in this PR but in Remove space from "Muse Sounds" to "MuseSounds" in app #26969
  • When opening a file from a previous version, the correct profile should still be selected when opening the file in this PR's build
  • When adding new instruments to such a file, they should automatically load the correct sounds according to the selected profile

@zacjansheski
Copy link
Contributor

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved

@RomanPudashkin RomanPudashkin merged commit 210738b into musescore:master Mar 10, 2025
11 checks passed
@RomanPudashkin RomanPudashkin deleted the musesounds_profile_rename branch March 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants