4.5.0 ports #26974
Merged
4.5.0 ports #26974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jojo-Schmitz
commented
Mar 7, 2025
Jojo-Schmitz
commented
- Fix "ambiguity" with Russian keyboard layout #26774
- #19359 export parts #25998
- fixed #25792: Weird first page of score appears when editing text #26949
- Fix #26854: Crash entering note input mode on percussion staff after changing panel preference #26946
- Input by duration: tutorial video link #26951
- Fix #26907: Avoid capturing notation in selectionChanged() #26964
Resolves: musescore#25824 When using Russian keyboard layout, and when there is a `Z` shortcut and a `Ctrl+Z` shortcut, and you press `Ctrl+Z`, we add four shortcuts: - `Z` and `Я` - `Ctrl+Z` and `Ctrl+Я` When pressing `Ctrl+Z`, Qt thinks there are two possible keys: ``` 17:42:43.971 | DEBUG | main_thread | Qt | - QKeyCombination(ControlModifier, Key(1071)) / QKeySequence("Ctrl+Я") / ⌘Я 17:42:43.971 | DEBUG | main_thread | Qt | - QKeyCombination(NoModifier, Key_Z) / QKeySequence("Z") / Z ``` (output seen after `QLoggingCategory::setFilterRules("qt.gui.shortcutmap.debug=true\nqt.qpa.keymapper.debug=true\nqt.qpa.keymapper.keys.debug=true");`) The latter, `Z` with no modifier, makes no sense to me, but whatever; Qt thinks it must be. As a result, Qt thinks the shortcuts are ambiguous: it doesn't know whether to activate `Z` or `Ctrl+Я`. The solution is to avoid adding `Z` as a shortcut; it won't be necessary anyway, as `Я` suffices. Same story goes for other single-letter shortcuts.
Addresses musescore#26774 (comment). Apparently the issue with ambiguous keys doesn't apply to the A key. It is totally unclear why. The possibility that there are other keys to which this applies too, has not been ruled out.
…thod selectAndStartEditIfNeeded checks the previous selection and the new selection and if it is different then it finishes editing the previous selection so we don't need to change the selection in cmdPaste
1. react to percussionPanelAutoShowModeChanged() 2. ensure we don't dispatch "set-dock-open" multiple times in succession
…o that it can be destroyed
Undo may cause the part to be destroyed, so we want to hold the pointer until it completes
RomanPudashkin
approved these changes
Mar 7, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.