Fix various issues with system objects and multirests #26965
+55
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixMistakeInValidMMRestLogic
branch
from
6d8bc56 to
f7b1328
Compare
|
@mike-spa Tested on Win10. It still occurs on my side.. bandicam.2025-03-07.17-26-55-901.mp4 |
|
@mike-spa It's ready for testing? |
|
@DmitryArefiev yes, it should be fixed now! |
|
@mike-spa Variation of #26930 (comment) still occurs bandicam.2025-03-10.01-10-20-693.mp4 |
mike-spa
force-pushed
the
fixMistakeInValidMMRestLogic
branch
from
f7a214a to
d260b22
Compare
mike-spa
changed the title
|
@DmitryArefiev ready for another round |
oktophonie
approved these changes
Mar 10, 2025
|
@mike-spa Sorry.. but I've found another two.. (I can log them separately)
bandicam.2025-03-10.15-56-02-073.mp4
bandicam.2025-03-10.15-58-19-970.mp4 |
mike-spa
force-pushed
the
fixMistakeInValidMMRestLogic
branch
from
d260b22 to
4618f5a
Compare
|
@DmitryArefiev ready for another round! |
|
@mike-spa All issues above look fine now, but I found some crashes (regression with master) Crash 1
bandicam.2025-03-11.14-06-58-633.mp4Crash 2
bandicam.2025-03-11.14-08-40-300.mp4 |
mike-spa
force-pushed
the
fixMistakeInValidMMRestLogic
branch
from
4618f5a to
282c58a
Compare
|
@DmitryArefiev ready for another round! |
|
@mike-spa Yeah! All seems to be fine now! |
|
Tested #26930 on Win10, Mac13.7.2, LinuxUbuntu24.04.2 LTS - FIXED |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26930