Small HarmonyLayout tidy #26647
Draft
Small HarmonyLayout tidy #26647
+136
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +31,33 @@ class System; | |||
| } | |||
|
|
|||
| namespace mu::engraving::rendering::score { | |||
| // Help class. | |||
| // Contains harmonies/fretboard per segment. | |||
| class HarmonyList : public std::vector<EngravingItem*> | |||
There was a problem hiding this comment.
Given that it's not used in the .h file, this declaration can be in the .cpp file as well. (The only reasons to put something in a .h file are either that it's necessary, or to expose it to other files.)
miiizen
force-pushed
the
harmonyLayoutTidy
branch
from
f1b87f8 to
10f3136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out not to be relevant for a different PR and does not need to be merged into 4.5