Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keysigs on section break #25260

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Oct 21, 2024

Resolves: #25168

  • On section break add key signatures, and mark them "forSectionBreak".
  • When removing section break, remove "for section break" signatures.
  • If signature already there, it is preserved (not marked "for section break" and not removed on section break deletion.
  • New signatures added to section break are also not marked as "for section break", so not removed on section break deletion.
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik
Copy link
Contributor Author

sammik commented Feb 27, 2025

Im just thinking, if this is not somehow overcomplicated.

May be simply adding key sig (and clef and timesig) always, when adding section break.

End when removing section break, we could leve them there.
(Or we could remove them, if they are same as preceding ones).

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 27, 2025

A section break basically starts a new piece, so should start like the very 1st measure of a score, Clef, time- and key signature, as per the staff settings (which can disable them), but without courtesies.
If those would be marked as 'generated', they'd vanish on section break removal I'd guess?

@sammik
Copy link
Contributor Author

sammik commented Feb 27, 2025

If those would be marked as 'generated', they'd vanish on section break removal I'd guess?

I think, mark them as "generated" is semantically incorrect.
And I think, it wouldnt work anyway, as I think, begining each system has "generated" signs, and they change themselves, if signature changes before them. Am I wrong?

@sammik sammik force-pushed the section-break-keysig branch 2 times, most recently from 3058c42 to 1bc91e8 Compare March 7, 2025 00:14
@sammik sammik marked this pull request as draft March 7, 2025 08:03
@sammik
Copy link
Contributor Author

sammik commented Mar 7, 2025

Doesnt work in parts.
Ill fix it.

@sammik sammik force-pushed the section-break-keysig branch from 1bc91e8 to 3021408 Compare March 7, 2025 08:30
@sammik sammik force-pushed the section-break-keysig branch from 3021408 to e4436ad Compare March 10, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key signatures after section break are not transposed by transpose dialog
4 participants