Skip to content

Support nil activestorage objects #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support nil activestorage objects #30

wants to merge 1 commit into from

Conversation

EdwardIII
Copy link

Fixes "Module::DelegationError: size delegated to attachment, but
attachment is nil"

Support nil activestorage objects
c140b79 
Fixes "Module::DelegationError: size delegated to attachment, but
attachment is nil"
@EdwardIII EdwardIII mentioned this pull request Aug 8, 2018
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+33.8%) to 98.764% when pulling c140b79 on adaodesign:support_empty_activestorage_files into 00cb914 on musaffa:master.

@musaffa
Copy link
Owner

musaffa commented Aug 8, 2018

  1. Need to fix the failing tests. Module::DelegationError can be replaced with a generic error.
  2. A similar change is needed in the file content type validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwardIII @coveralls @musaffa