Add 'does not include' assertion operator #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 16, 2021 10:01
…ontains the matched item path (index in the collection), useful for the
|
@pzavolinsky can you take a look? I'm not very experienced with that part of the code base to review. |
pzavolinsky
reviewed
Dec 6, 2021
| Scenario: {} does not include { "a": null } | ||
| Given A is {} | ||
| When asserting that A does not include { "a": null} | ||
| Then the assertion fails with {} does include {"a":null} |
There was a problem hiding this comment.
this doesn't look right, A does not have a null valued a property so the assertion should pass.
| @@ -0,0 +1,58 @@ | |||
| Feature: compare JSON does not include X | |||
There was a problem hiding this comment.
you should add compound operand tests for does not include, stuff like:
{ "a": 1 } does not include { "a": 1, "b": 2 }☝️ also what would be the right outcome of this? { "a": 1 } certainly doesn't include the full { "a": 1, "b": 2 } but it does include a part of it.
maybe we also need a does not overlap operator that distinguishes between inclusion and intersection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The negative version of
includeoperator seems to be missing, this PR tries to add itfindOffendingItemfn to utils so it can be reused in both Operations.subErrordescribes at which property therecursiveMatchfailed. But fordoes not includefailures, I just usederrorPath.When
does not includefails,errorPathindicates at which index the occurrence was indeed found (took the same approach asis notoperator)