Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapset.switch_to_new_mapset: make messenging verbose #44

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

griembauer
Copy link
Member

This PR switches the numerous grass.messages within mapset.switch_to_new_mapset to grass.verbose. While they are useful for debugging, these messages decrease readability of the grass logs in case many parallel processes are run and some sort of logging should take place.

@linakrisztian
Copy link
Contributor

Looks good to me. Just some minor idea: maybe it would be nice to have the newly created mapset printed within verbose mode (and not always quiet, as done now).

@griembauer
Copy link
Member Author

griembauer commented Jan 16, 2025

Looks good to me. Just some minor idea: maybe it would be nice to have the newly created mapset printed within verbose mode (and not always quiet, as done now).

Thanks! This is actually still the case as the new or existing mapset is printed in verbose:

   if new:
        grass.verbose(_(f"New mapset {new_mapset}"))
        grass.utils.try_rmdir(os.path.join(gisdbase, location, new_mapset))
    else:
        grass.verbose(_(f"Using, not deleting mapset {new_mapset}"))

@griembauer griembauer merged commit b231405 into main Jan 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants