[core] Add LocalizationProvider
#4620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
bharatkashyap
commented
Jan 23, 2025
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import { AuthenticationContext, SessionContext } from '@toolpad/core/AppProvider'; | |||
| import { AppProvider } from '@toolpad/core/AppProvider'; | |||
There was a problem hiding this comment.
This change on all demos is since none of the demos on this page were using the Account component inside the AppProvider - added that since I think that is expected use, and also allows demonstrating overriding global localization using the localeText prop.
Kept one example which still demonstrates using Account without AppProvider but the constituent context providers instead
bharatkashyap
commented
Jan 23, 2025
| } | ||
|
|
||
| const defaultAccountLocaleText: Pick<LocaleText, keyof AccountLocaleText> = { |
There was a problem hiding this comment.
Using component-level defaults as a worst-case default for standalone usage of the component without any context being provided, similar to Material UI practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
Rename some existing localization keys on the
Accountcomponent to make them part of the globalLocaleTextsignInLabel->accountSignInLabelsignOutLabel->accountSignOutLabeliconButtonAriaLabel->accountPreviewIconButtonLabelCloses Enable localization injection from outside for all texts #4565