[x-license] move test keys to a dedicated /test-keys subpath#22334
Open
aemartos wants to merge 4 commits intomui:masterfrom
Open
[x-license] move test keys to a dedicated /test-keys subpath#22334aemartos wants to merge 4 commits intomui:masterfrom
aemartos wants to merge 4 commits intomui:masterfrom
Conversation
aemartos
added
internal
Deploy previewhttps://deploy-preview-22334--material-ui-x.netlify.app/ Bundle size
PerformanceTotal duration: 1,019.44 ms 🔺+92.07 ms(+9.9%) | Renders: 30 (+0) | Paint: 1,466.02 ms 🔺+142.05 ms(+10.7%)
…and 9 more — details Check out the code infra dashboard for more information about this PR. |
…ut-of-public-internals-export
…ut-of-public-internals-export
aemartos
changed the title
…ut-of-public-internals-export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mui/x-license/internalsis the runtime entrypoint imported by every commercial package (data-grid-pro/premium, charts-pro/premium, date-pickers-pro, tree-view-pro, scheduler-premium) to wire upuseLicenseVerifierandWatermark. It was also re-exporting every entry oftest-keys.ts, 17 base64+md5 strings used only by tests, which leaked them into the public TypeScript surface and inflated CI bundle-size measurements.This PR is a refactor with no behavior change.
Motivation
internals' public type surface. Removing them avoids accidental adoption and frees us from supporting them as stable API.internalswithimport *, which forced test-keys into the count. The number it reports, and uses to gate regressions, will now reflect what real consumers actually pull.export *barrel chains are a known weak spot in older esbuild/SSR/edge runtimes. After this change, test-keys aren't reachable frominternalsat all.No production consumer was importing these symbols, so no runtime behavior changes.