[internal-gestures] Inline wheel-delta clamp per axis#22331
Merged
JCQuintas merged 1 commit intomui:masterfrom May 6, 2026
Merged
[internal-gestures] Inline wheel-delta clamp per axis#22331JCQuintas merged 1 commit intomui:masterfrom
JCQuintas merged 1 commit intomui:masterfrom
Conversation
The clamp loop iterated `['totalDeltaX', 'totalDeltaY', 'totalDeltaZ']` on every wheel event, allocating an array and a closure on a hot path. Replace it with three inline Math.min/Math.max expressions. Also hoist the sensitivity-and-invert factor into a local rather than recomputing the ternary three times.
JCQuintas
added
internal
Deploy previewhttps://deploy-preview-22331--material-ui-x.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
alexfauquette
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The clamp loop iterated
['totalDeltaX', 'totalDeltaY', 'totalDeltaZ']on every wheel event, allocating an array and a closure on a hot path.Replace it with three inline
Math.min/Math.maxexpressions and hoist the sensitivity-and-invert factor into a local rather than recomputing the ternary three times.