Skip to content

[MobileDatePicker] Implement openPickerIcon property #24708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[MobileDatePicker] Implement openPickerIcon property #24708

wants to merge 2 commits into from

Conversation

weslenng
Copy link

Closes #24511

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 31, 2021 •
edited
Loading

@material-ui/lab: parsed: +0.08% , gzip: +0.02%

Details of bundle changes

Generated by 🚫 dangerJS against b4404b9

oliviertassinari
oliviertassinari requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new prop should be part of the components prop

@weslenng
Copy link
Author

weslenng commented Jan 31, 2021 •
edited
Loading

The new prop should be part of the components prop

I tried to use the same implementation of KeyboardDateInput, why in that case it is not possible to do it in a similar way?

@github-actions github-actions bot mentioned this pull request Jan 31, 2021
Closed
@oliviertassinari
Copy link
Member

@weslenng We are moving away from this approach, for consistency in v5

@weslenng
Copy link
Author

weslenng commented Feb 1, 2021

Sorry, but I won't have time to dedicate to this PR for a while 😕

@weslenng weslenng closed this Feb 1, 2021
@weslenng weslenng deleted the next-issue-24511 branch February 1, 2021 01:28
@oliviertassinari
Copy link
Member

@weslenng No problem, thanks for having a look :)

@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari requested changes

Assignees
No one assigned
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] input end adornment doesn't open date picker
4 participants
@weslenng @mui-pr-bot @oliviertassinari @zannager