[docs] Migrate Onepirate to TypeScript #22295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
docs/src/pages/premium-themes/onepirate/modules/views/AppFooter.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/premium-themes/onepirate/modules/components/Paper.tsx
Outdated
Show resolved
Hide resolved
docs/src/pages/premium-themes/onepirate/modules/components/TextField.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <MuiTextField | ||
| InputProps={{ | ||
| ...disableUnderline, |
There was a problem hiding this comment.
Why introducing an intermediary variable?
There was a problem hiding this comment.
Good question. I introduced the intermediary because otherwise typescript gives an unexpected error that I haven't been able to diagnose:
src/pages/premium-themes/onepirate/modules/components/TextField.tsx(95,6): error TS2322: Type '{ required?: boolean | undefined; disabled?: boolean | undefined; error?: boolean | undefined; hidden?: boolean | undefined; dir?: string | undefined; label?: ReactNode; select?: boolean | undefined; ... 276 more ...; SelectProps: { ...; }; }' is not assignable to type '(IntrinsicAttributes & StandardTextFieldProps) | (IntrinsicAttributes & FilledTextFieldProps) | (IntrinsicAttributes & OutlinedTextFieldProps)'.
Type '{ required?: boolean | undefined; disabled?: boolean | undefined; error?: boolean | undefined; hidden?: boolean | undefined; dir?: string | undefined; label?: ReactNode; select?: boolean | undefined; ... 276 more ...; SelectProps: { ...; }; }' is not assignable to type 'OutlinedTextFieldProps'.
Types of property 'variant' are incompatible.
Type '"standard" | "filled" | "outlined" | undefined' is not assignable to type '"outlined"'.
Type 'undefined' is not assignable to type '"outlined"'.
There was a problem hiding this comment.
This makes me think of #15697
There was a problem hiding this comment.
That's actually a combination of props where we do want type-checking to fail. You pass disableUnderline which is only supported for the standard textfield but the props are defined in way that would accept filled or outlined.
Spreading is just a common mechanism to defeat excess property checks: microsoft/TypeScript#29883
oliviertassinari
approved these changes
Aug 21, 2020
|
@rothbart Great job, thanks |
rothbart
added a commit
to rothbart/onepirate-typescript
that referenced
this pull request
Aug 21, 2020
rothbart
added a commit
to rothbart/onepirate-typescript
that referenced
this pull request
Aug 21, 2020
eps1lon
pushed a commit
to eps1lon/material-ui
that referenced
this pull request
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typescript version of onepirate theme. This is based on my create-react-app and typescript implementation here: https://github.com/rothbart/onepirate-typescript
This also fixes a few small bugs in the onepirate theme: