Skip to content

[ListItem] Fix ContainerProps.className propagation #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ExpansionPanel/ExpansionPanel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { PaperProps, PaperClassKey } from '../Paper';

export interface ExpansionPanelProps
extends StandardProps<PaperProps, ExpansionPanelClassKey, 'onChange'> {
CollapseProps?: React.ComponentType<CollapseProps>;
CollapseProps?: Partial<CollapseProps>;
defaultExpanded?: boolean;
disabled?: boolean;
expanded?: boolean;
Expand Down
2 changes: 2 additions & 0 deletions src/List/ListItem.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ export interface ListItemProps
> {
button?: boolean;
component?: React.ReactType<ListItemProps>;
ContainerComponent?: React.ReactType<React.HTMLAttributes<HTMLDivElement>>;
ContainerProps?: React.HTMLAttributes<HTMLDivElement>;
dense?: boolean;
disabled?: boolean;
disableGutters?: boolean;
Expand Down
7 changes: 5 additions & 2 deletions src/List/ListItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class ListItem extends React.Component {
className: classNameProp,
component: componentProp,
ContainerComponent,
ContainerProps,
ContainerProps: { className: ContainerClassName, ...ContainerProps } = {},
dense,
disabled,
disableGutters,
Expand Down Expand Up @@ -123,7 +123,10 @@ class ListItem extends React.Component {
}

return (
<ContainerComponent className={classes.container} {...ContainerProps}>
<ContainerComponent
className={classNames(classes.container, ContainerClassName)}
{...ContainerProps}
>
<Component {...componentProps}>{children}</Component>
{children.pop()}
</ContainerComponent>
Expand Down
33 changes: 22 additions & 11 deletions src/List/ListItem.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,40 +111,51 @@ describe('<ListItem />', () => {
assert.strictEqual(wrapper.childAt(0).type(), 'div');
});

it('should accept a ContainerComponent property', () => {
it('should accept a component property', () => {
const wrapper = shallow(
<ListItem ContainerComponent="div">
<ListItem component="span">
<ListItemText primary="primary" />
<ListItemSecondaryAction />
</ListItem>,
);
assert.strictEqual(wrapper.hasClass(classes.container), true);
assert.strictEqual(wrapper.type(), 'div');
assert.strictEqual(wrapper.childAt(0).type(), 'div');
assert.strictEqual(wrapper.type(), 'li');
assert.strictEqual(wrapper.childAt(0).type(), 'span');
});

it('should accept a component property', () => {
it('should accet a button property', () => {
const wrapper = shallow(
<ListItem component="span">
<ListItem button>
<ListItemText primary="primary" />
<ListItemSecondaryAction />
</ListItem>,
);
assert.strictEqual(wrapper.hasClass(classes.container), true);
assert.strictEqual(wrapper.type(), 'li');
assert.strictEqual(wrapper.childAt(0).type(), 'span');
assert.strictEqual(wrapper.childAt(0).type(), ButtonBase);
});

it('should accet a button property', () => {
it('should accept a ContainerComponent property', () => {
const wrapper = shallow(
<ListItem button>
<ListItem ContainerComponent="div">
<ListItemText primary="primary" />
<ListItemSecondaryAction />
</ListItem>,
);
assert.strictEqual(wrapper.hasClass(classes.container), true);
assert.strictEqual(wrapper.type(), 'li');
assert.strictEqual(wrapper.childAt(0).type(), ButtonBase);
assert.strictEqual(wrapper.type(), 'div');
assert.strictEqual(wrapper.childAt(0).type(), 'div');
});

it('should allow customization of the wrapper', () => {
const wrapper = shallow(
<ListItem ContainerProps={{ className: 'bubu' }}>
<ListItemText primary="primary" />
<ListItemSecondaryAction />
</ListItem>,
);
assert.strictEqual(wrapper.hasClass(classes.container), true);
assert.strictEqual(wrapper.hasClass('bubu'), true);
});
});
});
3 changes: 3 additions & 0 deletions test/typescript/components.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,9 @@ const ListTest = () => (
</ListItemSecondaryAction>
</ListItem>
))}
<ListItem ContainerComponent="div" ContainerProps={{ className: 'demo' }}>
an item
</ListItem>
</List>
);

Expand Down