[form][field] Add 'onSubmit' validation mode
#3013
Merged
+1,057
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: form
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
force-pushed
the
form/submit-validation
branch
from
63c6d89 to
2d56111
Compare
mj12albert
commented
Oct 19, 2025
Comment on lines
+199
to
+208
| * Asynchronous functions are supported, but they do not prevent form submission | ||
| * when using `validationMode="onSubmit"`. |
There was a problem hiding this comment.
Not sure if it's a good idea to try to handle it, but its different from the native behavior anyway so I think we could just ignore and only document it for now, what do you think? @atomiks
There was a problem hiding this comment.
I don't think it's possible to support it given event.preventDefault() needs to be sync, it makes sense to document it here
mj12albert
force-pushed
the
form/submit-validation
branch
from
2d56111 to
7653f15
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
form/submit-validation
branch
from
7653f15 to
443266f
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
form/submit-validation
branch
14 times, most recently
from
e744eca to
730ccd2
Compare
|
Needs #3048 |
mj12albert
force-pushed
the
form/submit-validation
branch
from
730ccd2 to
ec66468
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
form/submit-validation
branch
from
ec66468 to
b19ec4a
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
form/submit-validation
branch
from
b19ec4a to
090a2ac
Compare
mj12albert
force-pushed
the
form/submit-validation
branch
from
090a2ac to
7eff286
Compare
mj12albert
force-pushed
the
form/submit-validation
branch
from
ccf5a57 to
4339422
Compare
mj12albert
added
the
breaking change
atomiks
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking:
<Field>'s defaultvalidationModeis now'onSubmit'.validationModecan be set on<Form>to configure all child<Field>svalidationMode: 'onSubmit'runs validations when the<Form>is first submitted, afterwards fields are re-validated on change.This mode matches native form submission behavior and the defaults of RA, Ariakit and react-hook-form.
Can be tested in the forms experiment though it's mostly
requiredvalidationsCloses #2142