[popover] Fix swiping or scrolling on nested popup dismissing popover on touch #3011
+184
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
type: bug
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
|
atomiks
force-pushed
the
fix/pointer-move-children
branch
from
1e49be7 to
f45a406
Compare
atomiks
force-pushed
the
fix/pointer-move-children
branch
from
23548eb to
a7806f2
Compare
atomiks
force-pushed
the
fix/pointer-move-children
branch
from
a7806f2 to
039fb7e
Compare
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
mnajdova
reviewed
Oct 24, 2025
There was a problem hiding this comment.
Csb with the fix: https://codesandbox.io/p/devbox/brave-butterfly-rm8zjs?workspaceId=ws_HE9JRzFW36Y2kpBoSwdvZ5
Can you elaborate why we are removing the way to customize the capture of the keyboard event using escape? What's the correlation to the bug?
| /** | ||
| * Determines whether to use capture phase event listeners. | ||
| */ | ||
| capture?: boolean | { escapeKey?: boolean; outsidePress?: boolean }; |
There was a problem hiding this comment.
Don't we still need this? Why was it removed?
There was a problem hiding this comment.
No, it's an option from Floating UI config, but we don't use it anywhere in our components, so it can be removed.
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3008
This ensures pressing on nested children (in the React tree) doesn't dismiss on
pointermove(swiping/scrolling) by using the capture event trick, which is already done for the other event handlersAlso refactored from pointer to touch events because (at least on non-iOS/on Chrome DevTools),
pointermovestops firing once scroll starts, whiletouchmovealways fires which ensures the popover always dismisses while scrolling awayNote: #2978 refactors away the timeout for the
handleCaptureInsidelogic - I will rebase one of the PRs depending on which is merged first