[utils] Make sure Store state is not mutable outside of the class

[michaldudak]

As stores are accessible to developers with the handle prop on several components, I made it harder to accidentally update the state directly by making it read-only.

[pkg-pr-new]

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3005

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3005

commit: 00c490e

[netlify]

✅ Deploy Preview for base-ui ready!

Name	Link
🔨 Latest commit	00c490e
🔍 Latest deploy log	https://app.netlify.com/projects/base-ui/deploys/68f1e48e2c6c500009369dee
😎 Deploy Preview	https://deploy-preview-3005--base-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[mui-bot]

Bundle size report

Bundle	Parsed size	Gzip size
@base-ui-components/react	🔺+102B(+0.03%)	🔺+32B(+0.03%)

Details of bundle changes

[romgrk]

I don't like this change, the state getter can lower performance a bit in extreme cases (like the Data Grid). In general I've tried to optimize the Store for performance first and simplicity second, so I aim to avoid defensive code patterns. I would prefer if we didn't merge this change, and we aimed to keep Store instances as an implementation detail - not accessible externally.

[atomiks]

I would prefer if we didn't merge this change, and we aimed to keep Store instances as an implementation detail - not accessible externally.

I agree with this - the exposed store instance it should be changed to only export a subset of methods/properties, to avoid breaking changes

[michaldudak]

We can't make it properly inaccessible from the outside, as store is a field in "handles" - data structures several components use to detach triggers.
I suppose it should be enough to mark the field as @internal in JSDOM and perhaps call it __store or similar instead to indicate it's not something to peek into.

[romgrk]

Marking the field as internal/private is enough imo.