[code-infra] Move away from monorepo dependency #2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
added
the
scope: code-infra
brijeshb42
commented
Oct 16, 2025
| "release:changelog": "tsx scripts/releaseChangelog.mts", | ||
| "release:publish": "pnpm publish --recursive --tag latest", | ||
| "release:publish:dry-run": "pnpm publish --recursive --tag latest --registry=\"http://localhost:4873/\"", | ||
| "release:tag": "node scripts/releaseTag.mjs --repo base-ui", |
There was a problem hiding this comment.
This is now done automatically through GH Actions.
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brijeshb42
force-pushed
the
remove-monorepo
branch
from
3fd7ae4 to
da0984d
Compare
Bundle size report
|
brijeshb42
force-pushed
the
remove-monorepo
branch
from
da0984d to
08081b2
Compare
LukasTy
reviewed
Oct 16, 2025
| - run: | ||
| name: Validate type declarations | ||
| command: pnpm validate-declarations | ||
| command: pnpm code-infra validate-built-types |
There was a problem hiding this comment.
Wasn't it executing different logic than the testBuildTypes? 🤔
There was a problem hiding this comment.
Yes. But both the scripts were doing similar checks. So I've merged them into a single cli.
There was a problem hiding this comment.
Gotcha.
Do we still need it here, especially since test_types already runs it? 🤔
There was a problem hiding this comment.
That's what we are discussing here - mui/mui-public#812 (comment)
| "@mui/internal-code-infra": "https://pkg.pr.new/mui/mui-public/@mui/internal-code-infra@8b697ae", | ||
| "@mui/internal-netlify-cache": "^0.0.2-canary.0", | ||
| "@mui/internal-test-utils": "^2.0.10", | ||
| "@mui/monorepo": "github:mui/material-ui#v7.3.2", |
LukasTy
approved these changes
Oct 16, 2025
michaldudak
reviewed
Oct 16, 2025
docs/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@mdx-js/mdx": "^3.1.1", | ||
| "@mui/internal-docs-infra": "https://pkg.pr.new/mui/mui-public/@mui/internal-docs-infra@8b697ae", |
There was a problem hiding this comment.
Do you intend to use the version published to npm before this is merged?
There was a problem hiding this comment.
Nope. I'll update it to the canary version.
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
remove-monorepo
branch
from
08081b2 to
f107892
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
approved these changes
Oct 17, 2025
Use the latest code-infra and docs-infra packages to move away from adding @mui/monorepo as a dependency. Related: mui/mui-public#812
brijeshb42
force-pushed
the
remove-monorepo
branch
from
f107892 to
d42a01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the latest code-infra and docs-infra packages to move away from adding @mui/monorepo as a dependency.
Related: mui/mui-public#812
Closes: #2951