-
-
Notifications
You must be signed in to change notification settings - Fork 254
[autocomplete][combobox] autoHighlight: "always", keepHighlight, highlightItemOnHover props
#2976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atomiks
wants to merge
14
commits into
mui:master
Choose a base branch
from
atomiks:feat/auto-highlight-behavior
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atomiks <[email protected]>
Signed-off-by: atomiks <[email protected]>
…e-onItemHighlighted
Signed-off-by: atomiks <[email protected]>
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Bundle size report
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: atomiks <[email protected]>
autoHighlight behavior configautoHighlight: "always", keepHighlight, focusItemOnHover props
autoHighlight: "always", keepHighlight, focusItemOnHover propsautoHighlight: "always", keepHighlight, focusItemOnHover props
f97bbcb to
7c2415c
Compare
autoHighlight: "always", keepHighlight, focusItemOnHover propsautoHighlight: "always", keepHighlight, highlightItemOnHover props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: autocomplete
Changes related to the autocomplete component.
component: combobox
Changes related to the combobox component.
PR: out-of-date
The pull request has merge conflicts and can't be merged.
type: new feature
Expand the scope of the product to solve a new problem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoHighlight: "always"for Autocomplete ensures the highlight is always visible even if not filtering. Useful for command paletteskeepHighlight: booleanretains the highlight when hovering out, useful if the highlight is linked to a side panel that should never disappearhighlightItemOnHoverdisables the highlight moving on hover if the focus and hover states should be differentiated (closes [combobox] No way for me to differentiate between hover and focus state on Combobox Items #2731) - https://codesandbox.io/p/sandbox/keen-mirzakhani-6tk996Closes #2922