Keep iOS chrome identified as safari because it is #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues (probably more):
#833
#825
#793
This section of code ends up causing issues in other areas because iOS Chrome is actually Safari (WKWebView technically). It does not support webm recording like usual Chrome, but instead natively supports mp4 recording like Safari. So you should not be making determinations of what is usually supported in Chrome if it is actually a WKWebView.
This causes the "auto"
recorderType
determination to end up trying to useWebAssemblyRecorder
when it should useMediaStreamRecorder
. Furthermore, if you forceMediaStreamRecorder
to be used, then it ends up failing theisMediaRecorderCompatible
check (because it thinks it is in Chrome but that helper internally doesn't factor in CriOS) which overrides anyrecorderHints
passed in.It's better to just treat CriOS browsers as Safari, because again it is a WKWebView which should be just viewed as Safari.