Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep iOS chrome identified as safari because it is #881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dparker2
Copy link

Related issues (probably more):
#833
#825
#793

This section of code ends up causing issues in other areas because iOS Chrome is actually Safari (WKWebView technically). It does not support webm recording like usual Chrome, but instead natively supports mp4 recording like Safari. So you should not be making determinations of what is usually supported in Chrome if it is actually a WKWebView.

This causes the "auto" recorderType determination to end up trying to use WebAssemblyRecorder when it should use MediaStreamRecorder. Furthermore, if you force MediaStreamRecorder to be used, then it ends up failing the isMediaRecorderCompatible check (because it thinks it is in Chrome but that helper internally doesn't factor in CriOS) which overrides any recorderHints passed in.

It's better to just treat CriOS browsers as Safari, because again it is a WKWebView which should be just viewed as Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant