Skip to content
This repository was archived by the owner on Aug 31, 2025. It is now read-only.

Conversation

@tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Jul 16, 2022

Fixes a bug where if the host Python is from the Windows store then DATA_DIR will be different with subproceses. This causes a crash creating virtual environments.

See mu-editor/crash-reports#228

Fixes #2293

@tonybaloney tonybaloney marked this pull request as ready for review July 16, 2022 13:47
@tonybaloney tonybaloney marked this pull request as draft July 16, 2022 14:11
@tonybaloney tonybaloney marked this pull request as ready for review July 16, 2022 15:05
@tjguk
Copy link
Collaborator

tjguk commented Jul 18, 2022

@tonybaloney would you mind running a make tidy over the PR and re-push, please? I'd be very keen to get this in once it's passing tests.

@tonybaloney
Copy link
Contributor Author

@tjguk done (the failing test is failing on all PRs)

@carlosperate
Copy link
Member

@tjguk done (the failing test is failing on all PRs)

Yes, the linux sementation fault used to be a lot more sporadic, now it seems to fail once in every CI run. We need to investigate further, but we haven't been able to replicate.

I've restarted the failing job, should pass the second time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Store Python causes crash on start

3 participants