Return NotFound instead of Error

mtotschnig · Jan 27, 2025 · 7662c05 · 7662c05
1 parent 45c091e
commit 7662c05
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/webui/src/main/java/org/totschnig/webui/WebInputService.kt b/webui/src/main/java/org/totschnig/webui/WebInputService.kt
@@ -553,13 +553,16 @@ class WebInputService : LifecycleService(), IWebInputService {
 
         get("/download/{file}") {
             val appDir = AppDirHelper.getAppDir(this@WebInputService).getOrThrow()
-            val inputStream = contentResolver.openInputStream(
-                appDir.findFile(call.parameters["file"]!!)!!.uri.let {
-                    AppDirHelper.ensureContentUri(it, this@WebInputService)
-                }
-            )!!
-            val channel = inputStream.toByteReadChannel()
-            call.respond(channel)
+            val file = appDir.findFile(call.parameters["file"]!!)?.uri?.let {
+                AppDirHelper.ensureContentUri(it, this@WebInputService)
+            }
+            if (file == null) {
+                call.respond(HttpStatusCode.NotFound, "File not found")
+            } else {
+                call.respond(
+                    contentResolver.openInputStream(file)!!.toByteReadChannel()
+                )
+            }
         }
     }