Skip to content

fix(Tabs): provide idSuffix as string #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x0dr1y
Copy link
Contributor

@0x0dr1y 0x0dr1y commented Jun 5, 2025

Fixes #14

Fixes an issue where the idSuffix was provided as a function instead of a string to the child components. This lead to broken ids being rendered in the DOM. I don't see a reason why this should be passed as a func, so i reckon this is the easiest way to solve the issue.

@mtorromeo
Copy link
Owner

Hi,
thanks for the report.

The change is incomplete as we either need to support optionally passing a ref or getter, or we need to also change the declaration of TabsProvide to properly declare that it is not supported (just string instead of MaybeRefOrGetter<string>).

Fixing support MaybeRefOrGetter<string> should be just a case of changing String(idSuffix) to toValue(idSuffix) probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs - idSuffix not resolved properly
2 participants