Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vacuum propagation rework #27

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

vacuum propagation rework #27

wants to merge 2 commits into from

Conversation

BuckarooBanzay
Copy link
Member

Performance tests

  • vmanip (iterative, nested)
    • 80 ms for a 20x20x20 cube
  • vmanip (flood-fill)
    • TBD
  • get/setnode (flood-fill)
    • TBD
  • mapblock-based (flood-fill, breaks current behavior!)
    • TBD

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jan 29, 2024
@BuckarooBanzay BuckarooBanzay self-assigned this Jan 29, 2024
Athozus
Athozus reviewed Apr 13, 2024
View reviewed changes
physics_propagation.lua
@@ -44,3 +45,68 @@ minetest.register_abm({
end
end)
})
--]]

minetest.register_chatcommand("test", {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debug command supposed to be there 😉

physics_propagation.lua
local area = VoxelArea:new({MinEdge=e1, MaxEdge=e2})
local node_ids = manip:get_data()

for z=ipos1.z, ipos2.z do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit scared by those nested fors, but it looks like that the limits are very close to each other.

Just wondering why using this syntax because after you are adding/subtracting 1 coordinate-by-coordinate.

@BuckarooBanzay
Copy link
Member Author

@Athozus this is still a work-in-progress PR (or draft in github terms) the /test command will go away if this ever works properly (expect more of these in the future this is the way i develop/prototype right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Athozus Athozus Athozus left review comments

Assignees

@BuckarooBanzay BuckarooBanzay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuckarooBanzay @Athozus