Skip to content

Replace minetest namespace with core #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 26, 2025
Merged

Replace minetest namespace with core #158

merged 11 commits into from
Jun 26, 2025

Conversation

The4codeblocks
Copy link
Contributor

No description provided.

@OgelGames OgelGames changed the title dedeprecate main namespace Replace minetest namespace with core May 2, 2025
OgelGames
OgelGames reviewed May 2, 2025
View reviewed changes
@OgelGames
Copy link
Contributor

OgelGames commented May 2, 2025 •
edited
Loading

Weird, why doesn't that work? We're using the master branch of luacheck 🤔

Critical error: in config loaded from .luacheckrc: invalid value of option 'std': unknown std 'luanti'

@The4codeblocks
Copy link
Contributor Author

yeah it doesn't work either way, for a quick fix, just add "core" to globals

@S-S-X
Copy link
Member

S-S-X commented May 2, 2025

Weird, why doesn't that work? We're using the master branch of luacheck 🤔

There's no official release yet, opened issue for this some time ago:

@BuckarooBanzay BuckarooBanzay added the cleanup code and other cleanups label May 7, 2025
@BuckarooBanzay
Copy link
Member

yeah it doesn't work either way, for a quick fix, just add "core" to globals

i'm fine with that too, a late luacheck release shouldn't block this from being merged IMO

@The4codeblocks
Copy link
Contributor Author

about this

@S-S-X
Copy link
Member

S-S-X commented May 29, 2025

That's about it, checks are passing now but didn't test.

S-S-X
S-S-X reviewed May 29, 2025
View reviewed changes
@S-S-X
Copy link
Member

S-S-X commented May 29, 2025

Didn't find anything unrelated besides that addition in filter-injector.lua

Is that fixing some bug? Should that addition be removed from this PR?

SwissalpS
SwissalpS reviewed Jun 4, 2025
View reviewed changes
@OgelGames OgelGames merged commit 2ebc4ac into mt-mods:master Jun 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwissalpS SwissalpS SwissalpS left review comments

@OgelGames OgelGames OgelGames left review comments

@S-S-X S-S-X S-S-X approved these changes

Assignees
No one assigned
Labels
cleanup code and other cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@The4codeblocks @OgelGames @S-S-X @BuckarooBanzay @SwissalpS