Skip to content

fluid system overhaul #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Conversation

The4codeblocks
Copy link
Contributor

@The4codeblocks The4codeblocks commented Apr 26, 2025

autocrafter fluid support
creative fluid source
trashcan acting as fluid void
flow sensor acting as a pressure gauge (shows fluid type too)
multiple fluid types (no mixing, but there is displacement)
| has custom fluid registration
| updating existing pump and drains to support multiple fluids
| per fluid "finite" config

(important detail: flow logic default set to "pressure" instead of "classic")

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Apr 28, 2025
@@ -48,7 +48,7 @@ pipeworks.toggles = {}
-- setting to nil inhibits all flow logic, useful for debugging ABM crashes,
-- or for rendering the pipes purely decorative.
]]
pipeworks.toggles.pipe_mode = "classic"
pipeworks.toggles.pipe_mode = "pressure"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does that affect existing worlds?

Copy link
Contributor Author

@The4codeblocks The4codeblocks Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of the things I'm doing (whether they're currently in this PR or not) are going to break things, but the old way things work is likely simple enough to auto-reinstate the original function

@BuckarooBanzay
Copy link
Member

Current luacheck warnings: (i removed the ones about missing core global)

Checking autocrafter.lua                          12 warnings

    autocrafter.lua:5:1: inconsistent indentation (SPACE followed by TAB)
    autocrafter.lua:17:1: line contains only whitespace
    autocrafter.lua:24:1: line contains only whitespace
    autocrafter.lua:181:1: line contains only whitespace
    autocrafter.lua:194:1: line contains only whitespace

 Checking common.lua                               1 warning

    common.lua:223:9: unused variable inv_size

Checking trashcan.lua                             2 warnings

    trashcan.lua:48:2: value assigned to field after_place_node is overwritten on line 53 before use
    trashcan.lua:49:2: value assigned to field after_dig_node is overwritten on line 56 before use

sounds good imo, didn't test that yet though

@The4codeblocks
Copy link
Contributor Author

feature set in desc updated

@The4codeblocks The4codeblocks changed the title some features fluid system overhaul May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants