expose tests as composite actions #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
For another data point, I did a PR for git-for-windows git-sdk-64 and msys2-runtime using a callable workflow. In that case, the lack of being able to add steps was OK because @dscho already had the workflow set up to get everything it's testing via artifacts, so doing any customization can be in a prior job that generates the artifacts. |
First part of making the tests a composite action that can be called from other repositories.
this will allow running them from another repository
jeremyd2019
force-pushed
the
composite-action
branch
from
57ee6d3 to
46ba34d
Compare
|
I've rebased this and included the changes from #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #24 (comment), this creates 2 composite actions: one that generates a matrix, and another that runs the tests. This allows the tests to be used easily from another repository. For an example of this, see msys2/msys2-runtime@msys2-3.6.0...jeremyd2019:msys2-runtime:run-tests (of course, the actions would be msys2/msys2-tests@main rather than my fork/branch).
The one mild drawback I saw with this is that it shows the entire composite action as one top-level "step" in the job view, but does still have the collapsed "group" for each sub-step showing the step information.
While testing this, I saw a failure due to the .lnk link files being larger than 1000 bytes, because when calling a composite action from another repository the path is longer. Added a fix for that.