Option to compile vendored source from either Samsung or Telegram #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
rlottie-sys
will keep searching for system-installed rlottie via pkg-config. If not found, it will download samsung's source and compile. Disablingvendor-samsung
disables it, enablingvendor-telegram
instead downloads telegram's source instead.I took some inspiration from #56 but chose not to use the
cmake
crate since I didn't see any value in a poorly documented opinionated glorified wrapper around a binary. If all it did was search forcmake
in different install locations and give me a nice api for specifying arguments that would be cool. But unfortunately it sets a bunch of crap without telling you and with no way of opting out. If they fix that and/or someone demonstrates how some obscure operating systems like Windows need that I'd be willing to revisit this decision.I also added include paths similar to #57 which is now necessary since the vendored source won't be in a default search path.