lk2nd: device: panel: remove failure on status is missing #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravMurav
reviewed
Feb 9, 2025
lk2nd/device/panel.c
Outdated
Comment on lines
100
to
106
| dprintf(CRITICAL, | ||
| "WARNING!!!!\n\ | ||
| Failed to enable %s touchscreen: %d\n\ | ||
| Please check your device tree.\n\ | ||
| Maybe a status property is missing from touchscreen nodes.\n", | ||
| panel->ts_compatible, | ||
| ret); |
There was a problem hiding this comment.
FWIW I'd use multiple dprintf so lk2nd prepends it's [000] timestamp to each, otherwise I'd use multiple string literals instead of escaping newline and adding 4 tabs to the string
dprintf(CRITICAL,
"foo\n"
"bar\n");
Remove failure when ts-compatible is in use and status property is missing from touchscreen node. Make a warning instead of fail. Signed-off-by: Barnabás Czémán <[email protected]>
barni2000
force-pushed
the
remove-failure
branch
from
5c98e17 to
acd7007
Compare
|
@TravMurav I have released the draft state, idk if it is possible to notify the users on splash if there is any warning message, maybe it would be a good approach in the future to make them check the logs. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove failure when ts-compatible is in use and status property is missing from touchscreen node. Make a warning instead of fail.
Issues:
Fixes: #482