Skip to content

Conversation

SuperchupuDev
Copy link

What is the purpose of this pull request?

Hi! Every big glob library (glob, globby, tinyglobby) except this one supports URLs in the cwd option, so for consistency I'm proposing adding it here too.

Since globby uses this library, adding support for this here would mean globby could drop its custom handling of URLs, and as such it could drop one whole dependency in globby!!

I've made sure the implementation is the same as what globby does.

What changes did you make? (Give an overview)

I've changed the Options interface's cwd property to string | URL, and changed the settings handler to convert the URL to a string if applicable.

I've also enabled esModuleInterop in the tsconfig.json, since due to an fdir update, it looks like typescript does not compile without this option enabled.

image

Doing this required me to change the snap-shot-it import to a default import:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant