Limited Redis client instance creation to main module#2
Open
johnrjj wants to merge 3 commits intomreschke:masterfrom
Open
Limited Redis client instance creation to main module#2johnrjj wants to merge 3 commits intomreschke:masterfrom
johnrjj wants to merge 3 commits intomreschke:masterfrom
Conversation
…, instead we can pool it across the goroutines
Owner
|
Awesome! Ill pull it in as soon as I can re-run the same tests to update the README.me with new results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the creation of a new redis client per every request has a significant bottleneck. Since you aren't creating a client per request in the nodejs version, this seems a bit more fair -- after the change, I found golang now beats out nodejs even at a concurrency of 1 when running apache bench (from 1.266 ms prechange to 0.588 ms postchange).