Skip to content

Fix for cdata containing two closing square brackets #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for cdata containing two closing square brackets #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd8958
Bugfix (for the bugfix): CDATA that contained ']]' was not read corre…
dummzeuch Sep 29, 2020
fb72261
used wrong type for ReadChar variable
dummzeuch Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions OmniXML.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3339,11 +3339,14 @@ procedure TXMLCDATASection.ReadFromStream(const Parent: TXMLNode; const InputStr
end
else
begin
InputStream.WriteOutputChar(ReadChar);
InputStream.WriteOutputChar(']');
if ReadChar = ']' then
PState := psEnd
else
else begin
InputStream.WriteOutputChar(']');
InputStream.WriteOutputChar(ReadChar);
PState := psData;
end;
end;
end;
end;
Expand Down