-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
ShadowNode: Inherit camera.layers only if shadow.camera.layers is not set #30877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RenaudRohlinger
merged 6 commits into
mrdoob:dev
from
RenaudRohlinger:utsubo/feat/shadow-allow-override
Apr 17, 2025
Merged
ShadowNode: Inherit camera.layers only if shadow.camera.layers is not set #30877
RenaudRohlinger
merged 6 commits into
mrdoob:dev
from
RenaudRohlinger:utsubo/feat/shadow-allow-override
Apr 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
sunag
reviewed
Apr 6, 2025
sunag
reviewed
Apr 8, 2025
Mugen87
reviewed
Apr 8, 2025
Mugen87
approved these changes
Apr 11, 2025
Should be a safe and useful addition. Since it's approved, I’ll go ahead and merge it. |
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
… set (mrdoob#30877) * ShadowNode: Inherit camera.layers only if shadow.layers is not set * Fix layers check * invert condition * restore after render * move array creation to module scope
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
… set (mrdoob#30877) * ShadowNode: Inherit camera.layers only if shadow.layers is not set * Fix layers check * invert condition * restore after render * move array creation to module scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #30156 #30856
Description
Only inherit the camera layers if
shadow.camera.layers
is not set. This allows selective real-time/static shadows and resolves #30156 and #30856. /cc @sunagThis contribution is funded by Renaud Rohlinger @ Utsubo