Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design update #16346

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Design update #16346

merged 1 commit into from
Apr 28, 2019

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Apr 28, 2019

@mrdoob mrdoob added this to the r105 milestone Apr 28, 2019
@mrdoob mrdoob merged commit 71511a5 into dev Apr 28, 2019
@fernandojsg
Copy link
Collaborator

I like the overall change, but I feel the color of the links on the left side are not consistent with the link colors on the right side

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 28, 2019

Yeah. Work in progress 😊

@fernandojsg
Copy link
Collaborator

👍

@linbingquan
Copy link
Contributor

I think use default font Microsoft YaHei is better in Chinese.

screenshot in font-family: "Microsoft YaHei"(cancle body font-family css in main.css)
image

screenshot in font-family: 'RobotoMono', monospace;
image

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 28, 2019

@yuinchien does that look good to you?

I guess I can implement it this way: https://stackoverflow.com/a/49490341

@yuinchien
Copy link
Contributor

@mrdoob didn't know how Chinese font look like in Window... Yes, Microsoft YaHei looks fine!

@yuinchien
Copy link
Contributor

yuinchien commented Apr 28, 2019

@mrdoob the md icons in the design are scaled down to 20x20 instead of the standard 24x24 because the standard vertical height for UI elements are slightly reduced, to better accommodate the large amount of content on the site.

Screen Shot 2019-04-28 at 9 52 04 AM

See the search icon in the design (left) is smaller. Body text would look less harsh in #222, than black too.

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 28, 2019

@yuinchien Yes, there are a lot of things to improve. We can go through them tomorrow 😊

@mrdoob
Copy link
Owner Author

mrdoob commented Apr 28, 2019

I managed to unify all the css though. I'm no longer ashamed of it! Haha

@mrdoob mrdoob deleted the design-update branch April 28, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants