Skip to content

video/out/gpu/context: add --gpu-debug-extra #16240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kasper93
Copy link
Member

No description provided.

@sfan5
Copy link
Member

sfan5 commented Apr 13, 2025

Why split this at all?

@kasper93
Copy link
Member Author

Why split this at all?

Excellent questions. I was thinking to put this into one option. The performance difference doesn't seem to be significant in our use of Vulkan and it's debug only option. Though currently it still does fail with synchronization validation (that -extra enables). See https://code.videolan.org/videolan/libplacebo/-/issues/333 so I didn't want to break gpu-debug with this.

Though if you prefer to have one option for this, I'm all for it. But it's more "aggressive" debugging.

I think in libplacebo it was split since the beginning, because of VVL bugs and false positives when enabling GPU-AV. This is mostly under control now.

Maybe @haasn has opinion? Maybe we merge this option in libplacebo even?

Copy link

github-actions bot commented Apr 13, 2025

Download the artifacts for this pull request:

Windows
macOS

@sfan5
Copy link
Member

sfan5 commented Apr 14, 2025

I don't have a strong opinion, but prefer to have a single option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants