console.lua: say focused instead of selected #16181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
kasper93
reviewed
Apr 4, 2025
| @@ -0,0 +1,2 @@ | |||
| rename `console-selected_color` script-opt to `console-focused_color` | |||
| rename `console-selected_back_color` script-opt to `console-focused_back_color` | |||
There was a problem hiding this comment.
We probably should provide backward compatibility
The selected term was causing confusion e.g. in mpv-player#15711 (comment). Saying either focused or current makes more sense since the item is not actually selected until you click or press Enter.
guidocella
force-pushed
the
console-focused
branch
from
0593321 to
71d372e
Compare
kasper93
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selected term was causing confusion e.g. in
#15711 (comment). Saying either focused or current makes more sense since the item is not actually selected until you click or press Enter.