github/workflows: make macos matrix job-names more telling #16152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cc/cxx values as part of the matrix don't differenciate the jobs, while the architecture does. Since cc/cxx are the same in all cases, just set them directly. In turn make the architecture value part of the job-labels and use exclude statements instead of include to limit the jobs accordingly.
kasper93
reviewed
Mar 29, 2025
| CC: "${{ matrix.cc }}" | ||
| CXX: "${{ matrix.cxx }}" | ||
| CC: "clang" | ||
| CXX: "clang++" |
|
Download the artifacts for this pull request: |
|
also pretty nit-picky, could you please write |
Akemi
reviewed
Mar 29, 2025
| - arch: "intel" | ||
| os: "macos-14" | ||
| - arch: "intel" | ||
| os: "macos-15" |
There was a problem hiding this comment.
a bit nit-picky, but i would prefer the order swapped, eg os first arch second. reason, same order as in the matrix and the OS version the primary/functional part. the arch is just used for the naming of the zip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cc/cxx values as part of the matrix don't differenciate the jobs, while the architecture does. Since cc/cxx are the same in all cases, just set them directly. In turn make the architecture value part of the job-labels and use exclude statements instead of include to limit the jobs accordingly.
While the other PR that adds a custom ffmpeg build w/libzvbi has been rejected, I think this one is still beneficial on its own.
instead of "clang, clang++, macos-13" and "clang, clang++, macos-14" having "macos-13, intel" and "macos-14, arm" is more useful.