console.lua: improve the hovered item calculation #15673
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename lines_max to max_lines which is the name used in other functions, and inline the log_messages variable because its name was confusing. The math.max(0, lines_max) call was not necessary because console doesn't crash with 0 or negative max lines.
This deduplicates the calculation of the y position by assigning it to a y variable, which will also be used in the next commit. margin_x is also renamed to x for consistency.
guidocella
force-pushed
the
console-mouse-fix
branch
from
c83aeb8 to
92be414
Compare
guidocella
changed the title
guidocella
force-pushed
the
console-mouse-fix
branch
from
92be414 to
17a16e4
Compare
|
Download the artifacts for this pull request: |
Currently determine_hovered_item() assumes that each item is opts.font_size pixels tall, which usually works well. This breaks with fonts that get drawn taller than that, such as Japanese text, which makes the calculation inaccurate for the top items and clips the counter. A couple of users reported that it is inaccurate for them for the top items even with ASCII characters in track selectors, presumably because the circles are taken from a different font and make all lines taller. To fix this place each selectable item in its own ASS event positioned like determine_hovered_item() expects.
guidocella
force-pushed
the
console-mouse-fix
branch
from
17a16e4 to
5ddf5a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.lua: improve the hovered item calculation
Currently determine_hovered_item() assumes that each item is opts.font_size pixels tall, which usually works well. This breaks with fonts that get drawn taller than that, such as Japanese text, which makes the calculation inaccurate for the top items and clips the counter. A couple of users reported that it is inaccurate for them for the top items even with ASCII characters in track selectors, presumably because the circles are taken from a different font and make all lines taller.
To fix this place each selectable item in its own ASS event positioned like determine_hovered_item() expects.
This should fix @sfan5's issue.