feat: extend Product Attribute Mapping functionality to AddToCart and Checkout #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
reviewed
Nov 25, 2025
src/FacebookEventForwarder.js
Outdated
| if (contents && contents.length > 0) { | ||
| params['contents'] = contents; | ||
| } | ||
| var contents = buildProductContents(event.ProductAction.ProductList); |
Collaborator
There was a problem hiding this comment.
var contents is being redeclared here. best to declar it at the top of the file rather than twice at 234/257
Contributor
Author
There was a problem hiding this comment.
Moved contents declaration to the top of the logCommerceEvent function (line 171)
rmi22186
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)